Use consts as predicate key names in handlers #59952
Conversation
resouer
added
the
sig/scheduling
k8s-ci-robot
added
release-note
resouer
requested review from
bsalamat
and removed request for
timothysc and
davidopp
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
added
the
approved
| // checkServiceAffinityPred defines the name of predicate checkServiceAffinity. | ||
| checkServiceAffinityPred = "checkServiceAffinity" | ||
| // CheckServiceAffinityPred defines the name of predicate checkServiceAffinity. | ||
| CheckServiceAffinityPred = "CheckServiceAffinity" |
There was a problem hiding this comment.
will that introduce backward compatibility?
There was a problem hiding this comment.
Should be fine. According to: https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/factory/plugins.go#L207-L218
The name of this predicate is not part of scheduler policy configure file.
There was a problem hiding this comment.
But there could be existing policy config files that are already using the old name.
There was a problem hiding this comment.
@bsalamat @k82cn AFAIK, the right way of using serviceAffinity in policy file is like below:
"apiVersion": "v1",
"kind": "Policy",
"predicates": [
{
"name": "NoVolumeZoneConflict"
},
{
"name": "MaxEBSVolumeCount"
},
{
"name": "MaxGCEPDVolumeCount"
},
{
"name": "MatchInterPodAffinity"
},
{
"name": "NoDiskConflict"
},
{
"name": "GeneralPredicates"
},
{
"name": "PodToleratesNodeTaints"
},
{
"name": "CheckNodeMemoryPressure"
},
{
"name": "CheckNodeDiskPressure"
},
{
"argument": {
"serviceAffinity": {
"labels": [
"region"
]
}
},
"name": "Region"
}
],
That's why I claim
The name of this predicate is not part of scheduler policy configure file
Since serviceAffinity is a argument which is not touched by this PR.
Correct me if I misunderstood sth :)
There was a problem hiding this comment.
Ah, I see. Thanks for clarification.
|
/lgtm cancel |
k8s-ci-robot
removed
lgtm
|
overall, it's LGTM, just want to make sure it's ok with compatibility :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, resouer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Per discussion in: https://github.com/kubernetes/kubernetes/pull/59335/files#r168351460
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #59951
Special notes for your reviewer:
Release note: